Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update charm documentation to mention required external access #59

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Update charm documentation to mention required external access #59

merged 1 commit into from
Nov 27, 2023

Conversation

mthaddon
Copy link

Applicable spec: N/A

Overview

Documentation change to mention required external access.

Rationale

We want to add reference documentation to each charm explaining what external access is required.

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

@mthaddon mthaddon requested a review from a team as a code owner November 27, 2023 13:00
@github-actions GitHub Actions
Copy link
Contributor

Test coverage for f60c5e1

Name                 Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------
src/charm.py           201     18     41      9    89%   126-129, 157-158, 178-179, 198, 239-241, 255->266, 274-278, 352->355, 377, 390, 399->402, 477
src/file_reader.py      17      0      6      0   100%
----------------------------------------------------------------
TOTAL                  218     18     47      9    90%

Static code analysis report

Run started:2023-11-27 13:02:03.945030

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1294
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@mthaddon mthaddon merged commit d0c246c into main Nov 27, 2023
19 checks passed
@mthaddon mthaddon deleted the external-access-doc branch November 27, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturo-seijas arturo-seijas arturo-seijas approved these changes

@jdkandersson jdkandersson jdkandersson approved these changes

Assignees
No one assigned
Labels
Libraries: OK trivial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mthaddon @jdkandersson @arturo-seijas